Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checks for bad wavetilts calibration #1873

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Added checks for bad wavetilts calibration #1873

merged 3 commits into from
Nov 20, 2024

Conversation

debora-pe
Copy link
Collaborator

As titled.

Copy link
Collaborator

@kbwestfall kbwestfall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Should we run tests?

@debora-pe
Copy link
Collaborator Author

Run tests. All good (unit tests failures due a problem that my machine has with setup_gui - not related to this PR).

Test Summary
--------------------------------------------------------
--- PYTEST PYPEIT UNIT TESTS PASSED  257 passed, 63 warnings in 358.69s (0:05:58) ---
--- PYTEST UNIT TESTS FAILED  6 failed, 145 passed, 168 warnings, 2 errors in 1708.33s (0:28:28) ---
--- PYTEST VET TESTS PASSED  63 passed, 99 warnings in 5455.90s (1:30:55) ---
--- PYPEIT DEVELOPMENT SUITE PASSED 248/248 TESTS  ---
Testing Started at 2024-11-18T17:16:27.929519
Testing Completed at 2024-11-19T07:51:22.169800
Total Time: 14:34:54.240281

@profxj profxj merged commit e11a386 into develop Nov 20, 2024
18 checks passed
@debora-pe debora-pe deleted the fix_tilts branch November 20, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants