Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝💄 Split the "process" change log entry to 3 #12853

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented Jul 15, 2024

Previously, the change log had a section called "Process". And some of
the incoming pull requests would add change notes there when they
couldn't be put into other categories. Using it like that is not a
good idea. This patch rethinks the categorization and the audiences of
a few common change types and defines respective categories that
replace "Process".

The new categories are:

  • packaging -- news for downstream re-packagers

  • contrib -- news for regular project participants

  • misc -- public change log for things that don't fit anywhere but
    are useful

Resolves #12555

Change note demo: https://pip--12853.org.readthedocs.build/en/12853/news/#contributor-facing-changes

webknjaz added 2 commits July 15, 2024 12:19
This is a preparatory step for further adding of new changelog
fragment types.
Said commit is a formatting change.
@webknjaz webknjaz requested review from sbidoul and pradyunsg July 15, 2024 11:41
@webknjaz webknjaz force-pushed the maintenance/towncrier-packaging-n-contrib-types branch from bbc6990 to cf01718 Compare July 15, 2024 16:35
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! This PR is a candidate for a contrib news, right?

@webknjaz webknjaz force-pushed the maintenance/towncrier-packaging-n-contrib-types branch from cf01718 to 9e6f247 Compare July 15, 2024 16:56
@webknjaz
Copy link
Member Author

Looks good, thanks! This PR is a candidate for a contrib news, right?

@sbidoul yes! I adjusted a few things to make the linters pass and added that fragment. I was in a bit of a hurry to get off the train on the way home from EuroPython, and so I missed this. It should be good now.

N.B. I also noticed that despite the contrib guide saying that trivial fragments are to be empty, I've found a few with text. I didn't change them, since that's out of the scope, but we should probably lint this case and prevent it from happening. I filed sanitizers/chronographer-github-app#39 to implement the check in the app at some point, but I'll try to also add a pre-commit based implementation for now.

@webknjaz webknjaz force-pushed the maintenance/towncrier-packaging-n-contrib-types branch from 9e6f247 to 864eff4 Compare July 15, 2024 17:02
@@ -110,8 +110,8 @@ public is concerned, typo fixes, white space modification, etc. To mark a PR
as trivial a contributor simply needs to add a randomly named, empty file to
the ``news/`` directory with the extension of ``.trivial.rst``. If you are on a
POSIX like operating system, one can be added by running
``touch news/$(uuidgen).trivial.rst``. On Windows, the same result can be
achieved in Powershell using ``New-Item "news/$([guid]::NewGuid()).trivial.rst"``.
``touch news/+$(uuidgen).trivial.rst``. On Windows, the same result can be
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbidoul FYI, fragments with the leading + are called “orphan” within Towncrier and so it's usually good to follow their conventions for this random stuff that might not need to link issue/PR numbers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL. Thanks!

Previously, the change log had a section called "Process". And some of
the incoming pull requests would add change notes there when they
couldn't be put into other categories. Using it like that is not a
good idea. This patch rethinks the categorization and the audiences of
a few common change types and defines respective categories that
replace "Process".

The new categories are:

  * `packaging` -- news for downstream re-packagers

  * `contrib` -- news for regular project participants

  * `misc` -- public change log for things that don't fit anywhere but
    are useful

Resolves pypa#12555
@webknjaz webknjaz force-pushed the maintenance/towncrier-packaging-n-contrib-types branch from 864eff4 to 6e5fb51 Compare July 15, 2024 17:12
@webknjaz
Copy link
Member Author

@pradyunsg ping

Comment on lines +96 to +97
)(\.\d+)?(\.rst)?
|[0-9a-zA-Z-_]+\.vendor(\.\d+)?(\.rst)? # special-case vendoring
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
)(\.\d+)?(\.rst)?
|[0-9a-zA-Z-_]+\.vendor(\.\d+)?(\.rst)? # special-case vendoring
)(\.\d+)?\.rst
|[0-9a-zA-Z-_]+\.vendor(\.\d+)?\.rst # special-case vendoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Making the changelog audience-oriented
2 participants