Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the xref kind arg onto a field of the TypeXRefInternal #160

Merged
merged 1 commit into from
May 7, 2024
Merged

Move the xref kind arg onto a field of the TypeXRefInternal #160

merged 1 commit into from
May 7, 2024

Conversation

hoodmane
Copy link
Member

@hoodmane hoodmane commented May 6, 2024

This field is always None unless the argument is a TypeXRefInternal so it makes more sense to put it as a field.

@hoodmane hoodmane changed the title Move the xref kind field onto the TypeXRefInternal Move the xref kind arg onto a field of the TypeXRefInternal May 6, 2024
@hoodmane hoodmane merged commit 5d4ca7b into pyodide:master May 7, 2024
8 checks passed
@hoodmane hoodmane deleted the xref-kind-to-xref branch May 7, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hoodmane