Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type parameters to rendered rst for functions, classes, and interfaces #148

Merged
merged 4 commits into from
May 6, 2024

Conversation

hoodmane
Copy link
Member

@hoodmane hoodmane commented May 4, 2024

When rendering a jsfunction, jsclass, or jsinterface, if there are type params include them. Like:

function f<S, T>(x, y)

I also removed the parens from classes and interfaces because they look weird.

We had to add an extra docutils node for js-type-params because the normal type params docutils node uses square brackets not angle brackets.

@hoodmane hoodmane force-pushed the type-params branch 2 times, most recently from 4da76b3 to 1c092f6 Compare May 4, 2024 15:09
@hoodmane hoodmane changed the title Add type parameters to rendered rst Add type parameters to rendered rst for functions, classes, and interfaces May 4, 2024
@hoodmane hoodmane merged commit fb88024 into pyodide:master May 6, 2024
8 checks passed
@hoodmane hoodmane deleted the type-params branch May 6, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant