Add more sphinxJsConfig hooks #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added hooks preConvert and postConvert. preCommit receives just the typedoc app and runs right after application bootstrap. (To run earlier I think you'd need to make an actual typedoc plugin). `postConvert` runs right at the end. I also added a map from typedoc reflections to the corresponding ir item that postConvert can look at. I also added an extra_data dictionary which we pass to Python so that implementations of these hooks can pass extra information to be handled on the Pythons side. (None of the Python-side hooks can use this info yet, it can only be used via a monkeypatch.) No test coverage for any of this...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added hooks preConvert and postConvert. preConvert receives just the typedoc app and runs right after application bootstrap. (To run earlier I think you'd need to make an actual typedoc plugin).
postConvertruns right at the end. I also added a map from typedoc reflections to the corresponding ir item that postConvert can look at. I also added an extra_data dictionary which we pass to Python so that implementations of these hooks can pass extra information to be handled on the Pythons side. (None of the Python-side hooks can use this info yet, it can only be used via a monkeypatch.)No test coverage for any of this...