Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pydantic V2 #113

Closed
wants to merge 8 commits into from
Closed

Use Pydantic V2 #113

wants to merge 8 commits into from

Conversation

ryanking13
Copy link
Member

Bump pydantic version to v2. I tried to update the pydantic version following the migration guide, but after migration, the tests started to blow up.

So this PR updates the pydantic version but replaces all import pydantic to import pydantic.v1 so everything works as before.

@ryanking13
Copy link
Member Author

FAILED tests/test_build_ts/test_build_ts.py::TestTextBuilder::test_example - AssertionError: assert 'exampleFunct...hing python\n' == 'exampleFunct...hing python\n'
  
  Skipping 60 identical leading characters in diff, use -v to show
  -   Example: This is another example.
  +   Example:
    
          Something python

It looks like this test is failing in the main branch, too...

@ryanking13
Copy link
Member Author

Pinning typedoc version to 0.25.0 (latest version is 0.25.13) seems to work.

@hoodmane
Copy link
Member

I fixed the test failures #114

@ryanking13
Copy link
Member Author

I fixed the test failures #114

Great, thanks! Reverted pinning typedoc version.

@ryanking13 ryanking13 closed this May 2, 2024
@ryanking13 ryanking13 deleted the pydantic-v2 branch May 2, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants