Skip to content

Commit

Permalink
Set --exclude-private to false (#176)
Browse files Browse the repository at this point in the history
  • Loading branch information
hoodmane authored Dec 23, 2024
1 parent 23ae2e4 commit 52f13eb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions sphinx_js/typedoc.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ def typedoc_output(
command.add("--tsconfig", tsconfig_path)

command.add("--basePath", base_dir)
command.add("--excludePrivate", "false")

with NamedTemporaryFile(mode="w+b", delete=False) as temp:
command.add("--json", temp.name, *abs_source_paths)
Expand Down
6 changes: 4 additions & 2 deletions tests/test_typedoc_analysis/test_typedoc_analysis.py
Original file line number Diff line number Diff line change
Expand Up @@ -325,10 +325,11 @@ def test_properties(self):
m
for m in cls.members
if isinstance(m, Attribute)
and m.name in ["someStatic", "someOptional", "someNormal"]
and m.name
in ["someStatic", "someOptional", "somePrivate", "someNormal"]
]
)
== 3
== 4
)

# The unique things about properties (over and above Variables) are set
Expand All @@ -340,6 +341,7 @@ def get_prop(delim: str, val: str) -> Attribute:

assert get_prop(".", "someStatic").is_static
assert get_prop("#", "someOptional").is_optional
assert get_prop("#", "somePrivate").is_private
normal_property = get_prop("#", "someNormal")
assert (
not normal_property.is_optional
Expand Down

0 comments on commit 52f13eb

Please sign in to comment.