Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bundling of .so files that got broken once pyodide switched to using
loadDynlib
, previously we were hooking into emscripten'sFS.findObject
but this no longer works with recent pyodide versions.The logic added here is,
searchDirs
passed toloadDynlib
. It's a known issue that should be fixed later. At least this PR fixes the scipy example, so it's already an improvement.loadDynlib
in the same order.FS.readFile
as we are doing in Pyodide as I'm not sure how much it matters, but maybe I should.With the scipy example,
It's not too bad but also not exceptional. The next step would be to strip .so of unused symbols (though that requires good coverage in the sample code). In particular, this example is a random forest example and I think it doesn't need any of the BLAS functions (and likely very little from scipy).
cc @ryanking13