CI Run tests with pyodide 0.24.0 #85
Conversation
ryanking13
changed the title
.github/workflows/main.yml
Outdated
| @@ -18,7 +18,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [ubuntu-20.04] | |||
| pyodide-version: [0.22.1, 0.23.2] | |||
| pyodide-version: [0.24.0] | |||
There was a problem hiding this comment.
Should we document a compatibility matrix somewhere? Of compatible Pyodide version for a given micropip release?
micropip/_compat_in_pyodide.py
Outdated
| # TODO: replace with response.headers when pyodide>= 0.24 is released | ||
| headers: dict[str, str] = Object.fromEntries( | ||
| response.js_response.headers.entries() | ||
| ).to_py() |
There was a problem hiding this comment.
So it's a bit of a question how fast we drop support for older pyodide releases in micropip.
I'm not opposed to doing this but just something I wonder about, especially that here there is no major benefits from updating (aside from having slightly simpler code in this case).
|
@rth Hmm, yes that's a good point. As you mentioned, there isn't much benefit from dropping Pyodide < 0.24.0 here in this PR, so I'll revert that change, and add some compatibility table. I suppose we could do something like |
Co-authored-by: Hood Chatham <[email protected]>
for more information, see https://pre-commit.ci
Useresponse.headerswhich is added in Pyodide 0.24.