Add basic integration tests #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
reviewed
Dec 5, 2024
|
|
||
|
|
||
| def test_integration_install_basic(selenium_standalone_micropip, pytestconfig): | ||
| pytestconfig.getoption("--integration", skip=True) |
There was a problem hiding this comment.
Can we make a separate fixture or decorator for this so that we can say:
@integration_only
@run_in_pyodide
def test_integration_install_basic(selenium_standalone_micropip):
# test bodyOr maybe it would be possible to skip the entire file instead of each test individually?
hoodmane
reviewed
Dec 5, 2024
hoodmane
reviewed
Dec 5, 2024
hoodmane
reviewed
Dec 5, 2024
| @@ -1,7 +1,7 @@ | |||
| # This file contains tests that actually query remote package indexes, | |||
| # to ensure that micropip works with real-world package indexes. | |||
| # Since running these tests will send many requests to remote servers, | |||
| # these tests are disabled by default. | |||
| # these tests are disabled by default in CI. | |||
There was a problem hiding this comment.
Above you said: "To run these tests locally, add --integration flag". Here you say they are disabled by default in CI. But aren't they are also disabled by default locally?
There was a problem hiding this comment.
Right, they are disabled both locally and CI by default. I'll update the wording
hoodmane
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Thanks @ryanking13! I have some nits but generally looks good.
Co-authored-by: Hood Chatham <[email protected]>
Co-authored-by: Hood Chatham <[email protected]>
for more information, see https://pre-commit.ci
…opip into integration-test
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic integration tests for micropip, which queries to real world packages indexes (PyPI).
To prevent DoS, this is disabled by default in PR, and only run when
[integration]is included in the PR or when the PR is merged and pushed to the main branch.