Port install into PackageManager
#119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanking13
approved these changes
Jul 7, 2024
| """ | ||
|
|
||
| def __init__(self) -> None: | ||
| self.index_urls = package_index.DEFAULT_INDEX_URLS | ||
| self.index_urls = package_index.DEFAULT_INDEX_URLS[:] |
micropip/package_manager.py
Outdated
| @@ -6,31 +6,52 @@ | |||
| from micropip import package_index | |||
| from micropip._commands import mock_package | |||
| from micropip.freeze import freeze_lockfile | |||
| from micropip.install import install | |||
| from micropip.list import list_installed_packages | |||
| from micropip.package import PackageDict | |||
There was a problem hiding this comment.
Let's change import paths to relative paths.
from .package import PackageDict
# same for other imports
There was a problem hiding this comment.
Sure, but I'm curious about the reasoning behind this change? (Personally I don't see a significant advantage over one another)
There was a problem hiding this comment.
It distinguishes the local imports from external imports. Also, a minor benefit would be that if we change the package name, it does not need to be updated.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
installintoPackageManagerinstallto parent directory(to avoid importing_commands.install.pyfrompackage_manager.py)This concludes implementing the global commands in
PackageManager, thus making it viable for use, although it doesn't really serve a separated purpose for end users at the moment. Adding customisability to inner behavior via this abstraction may be a later goal.