Address reviews

pyodide · Dec 28, 2023 · 6885216 · 6885216
1 parent b254cb7
commit 6885216
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/micropip/_compat_in_pyodide.py b/micropip/_compat_in_pyodide.py
@@ -22,12 +22,11 @@
 async def fetch_bytes(url: str, kwargs: dict[str, str]) -> bytes:
     parsed_url = urlparse(url)
     if parsed_url.scheme == "emfs":
-        result_bytes = Path(parsed_url.path).read_bytes()
-    elif parsed_url.scheme == "file":
-        result_bytes = (await loadBinaryFile(parsed_url.path)).to_bytes()
-    else:
-        result_bytes = await (await pyfetch(url, **kwargs)).bytes()
-    return result_bytes
+        return Path(parsed_url.path).read_bytes()
+    if parsed_url.scheme == "file":
+        return (await loadBinaryFile(parsed_url.path)).to_bytes()
+
+    return await (await pyfetch(url, **kwargs)).bytes()
 
 
 async def fetch_string_and_headers(

diff --git a/micropip/_compat_not_in_pyodide.py b/micropip/_compat_not_in_pyodide.py
@@ -20,8 +20,7 @@ def _fetch(url: str, kwargs: dict[str, Any]) -> addinfourl:
 
 
 async def fetch_bytes(url: str, kwargs: dict[str, Any]) -> bytes:
-    response = _fetch(url, kwargs=kwargs)
-    return response.read()
+    return _fetch(url, kwargs=kwargs).read()
 
 
 async def fetch_string_and_headers(