This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
fix implementation of connect header to allow header sized above 128 bytes #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This is not just an issue with the connect() message - it is also implicit in subscribe(). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This change fixes a bug in the mqtt.py CONNECT message implementation, where the connection would be reset by the broker right after your device has send the CONNECT message. The error is, that mqtt.py does implement the "Remaining Length" field correctly for values above 128.
Does this close any currently open issues?
#130
Any other comments?
The publish packet seems to implement this field correctly.
Anyway, I only found that out after fixing the bug myself, so feel free to reject or modify the PR.
Where has this been tested?
os.uname()output:(sysname='esp32', nodename='esp32', release='1.12.0', version='v1.12-464-gcae77daf0-dirty on 2020-06-28', machine='ESP32 module with ESP32')