Revert "Add -Wl,-z,undefs to linux links" #98
Conversation
This reverts commit a29d777.
| @@ -68,10 +68,7 @@ def pybind_extension( | |||
| linkopts = linkopts + select({ | |||
| "@platforms//os:osx": ["-undefined", "dynamic_lookup"], | |||
| Label("@pybind11//:msvc_compiler"): [], | |||
| "//conditions:default": [ | |||
| "-Wl,-Bsymbolic", | |||
| "-Wl,-z,undefs", | |||
There was a problem hiding this comment.
Do you still need "-Wl,-z,undefs"?
There was a problem hiding this comment.
I don't. I am just reverting the PR to restore the previous working state.
There was a problem hiding this comment.
@jiawen Kind reminder
There was a problem hiding this comment.
My apologies. I've been slammed with other stuff but I'll take a look at it this weekend.
There was a problem hiding this comment.
Sorry this took so long. I finally skimmed what -z undefs means (thanks @MaskRay !) - yeesh this is a rabbit hole I did not expect to go into.
For some reason, I misread your PR - -Wl,-Bsymbolic was pre-existing. Approving now.
| @@ -68,10 +68,7 @@ def pybind_extension( | |||
| linkopts = linkopts + select({ | |||
| "@platforms//os:osx": ["-undefined", "dynamic_lookup"], | |||
| Label("@pybind11//:msvc_compiler"): [], | |||
| "//conditions:default": [ | |||
| "-Wl,-Bsymbolic", | |||
| "-Wl,-z,undefs", | |||
There was a problem hiding this comment.
Sorry this took so long. I finally skimmed what -z undefs means (thanks @MaskRay !) - yeesh this is a rabbit hole I did not expect to go into.
For some reason, I misread your PR - -Wl,-Bsymbolic was pre-existing. Approving now.
Reverts #90 which introduced #94 causing also issues for https://github.com/pybind/pybind11_abseil. The revert closes #94.