Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json for all-contribs #4669

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Fix json for all-contribs #4669

merged 4 commits into from
Dec 12, 2024

Conversation

kratman
Copy link
Contributor

@kratman kratman commented Dec 12, 2024

Description

Fixes a typo

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python -m pytest (or $ nox -s tests)
  • The documentation builds: $ python -m pytest --doctest-plus src (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Saransh-cpp
Saransh-cpp previously approved these changes Dec 12, 2024
Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, should have caught this in the review. Thanks!

@kratman kratman enabled auto-merge (squash) December 12, 2024 13:17
@kratman
Copy link
Contributor Author

kratman commented Dec 12, 2024

@Saransh-cpp CI stalled here, I don't think my bot-fix worked. I will try again

@kratman kratman disabled auto-merge December 12, 2024 14:51
@kratman kratman merged commit 62e8f3b into develop Dec 12, 2024
23 of 24 checks passed
@kratman kratman deleted the kratman-patch-1 branch December 12, 2024 20:34
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.21%. Comparing base (72c23ea) to head (6681af2).
Report is 22 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4669   +/-   ##
========================================
  Coverage    99.21%   99.21%           
========================================
  Files          302      302           
  Lines        22858    22878   +20     
========================================
+ Hits         22679    22699   +20     
  Misses         179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants