Remove dev installation of VCPKG

[kratman]

Description

Removes outdated dev installation of VCPKG during the release

Fixes #4632
Related PR: pybamm-team/pybammsolvers#13
Wheel build: kratman#8

Key checklist:

• No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All tests pass: $ python -m pytest (or $ nox -s tests)
• The documentation builds: $ python -m pytest --doctest-plus src (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.21%. Comparing base (72c23ea) to head (d43851c).
Report is 3 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #4633   +/-   ##
========================================
  Coverage    99.21%   99.21%           
========================================
  Files          302      302           
  Lines        22858    22858           
========================================
  Hits         22679    22679           
  Misses         179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Saransh-cpp]

Thanks, @kratman! Looks good to me!

PS: I am opening these difficulty: easy issues for a good-first-issue hackathon at UCL tomorrow (you might have missed this on slack). I would appreciate if they stay open for open-source newbies (most of them are low priority - most development in vcpkg these days is updating mirrors or ports of the packages, so removing the dev installation is not a high priority issue).

[kratman]

Thanks, @kratman! Looks good to me!

PS: I am opening these difficulty: easy issues for a good-first-issue hackathon at UCL tomorrow (you might have missed this on slack).

I saw that some were being opened for the hackathon, however, this one was related to the IDAKLU separation and I needed to do it in another repo as well

[Saransh-cpp]

Ah, I see. Just to be safe, having the dev version of vcpkg should not intervene with the separation in any way (and there is something wrong if it is popping up as a problem in pybammsolvers and not in PyBaMM).

[kratman]

Ah, I see. Just to be safe, having the dev version of vcpkg should not intervene with the separation in any way (and there is something wrong if it is popping up as a problem in pybammsolvers and not in PyBaMM).

It is not interfering, I am just trying to keep the wheel builds in sync until I get time to wrap up the last of it