-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v24.5 #4289
Release v24.5 #4289
Conversation
update Arg pybamm.Experiment.period
…uElysia docs: add AndyLiuElysia as a contributor for doc
* #3526 initialise branch * #3256 add UpwindDivergence and DownwindDivergence * work in progress for fixing upwind scheme * #3526 add missing argument docstring * #3526 fix upwind/downwind methods * style: pre-commit fixes * #3526 get finite volume notebook from develop * 3526 add temporary test * ruff * style: pre-commit fixes * #3526 remove unused variable * #3526 clarify wording * #3526 fix tests * #3526 add to CHANGELOG * #3526 update coverage * #3526 add integration test * style: pre-commit fixes * #3526 remove example for debugging * Remove print for debug Co-authored-by: Eric G. Kratz <[email protected]> * #3526 add second test * #3526 generalised example but did not add test as was hard to know what to measure * style: pre-commit fixes --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Eric G. Kratz <[email protected]> Co-authored-by: Valentin Sulzer <[email protected]>
Add normal pdf and cdf functions
Remove RMSE function
…le() (#4005) * add return type for util.have_jax() and is_jax_compatible() * add description * Update pybamm/util.py Co-authored-by: Agriya Khetarpal <[email protected]> --------- Co-authored-by: Eric G. Kratz <[email protected]> Co-authored-by: Agriya Khetarpal <[email protected]>
* convert global start context to individual pool context * Update context creation, add tests for coverage --------- Co-authored-by: Valentin Sulzer <[email protected]> Co-authored-by: Eric G. Kratz <[email protected]>
…dependency (#3968) * Edit pybamm import test * Guard pybtex imports * Update pybamm/citations.py Co-authored-by: Agriya Khetarpal <[email protected]> * Update pybamm/citations.py (1) Co-authored-by: Agriya Khetarpal <[email protected]> * Update pybamm/citations.py (2) Co-authored-by: Agriya Khetarpal <[email protected]> * Update pybamm/citations.py (3) Co-authored-by: Agriya Khetarpal <[email protected]> * Update contributing guidelines * Exclude excepts from test coverage * style: pre-commit fixes --------- Co-authored-by: Lorenzo Favaro <[email protected]> Co-authored-by: Agriya Khetarpal <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Eric G. Kratz <[email protected]> Co-authored-by: Arjun Verma <[email protected]>
* reduced the image to one * removed build time args and multiple image builds * removed optional solvers from docker docs * Apply suggestions from code review Co-authored-by: Agriya Khetarpal <[email protected]> * code review suggestions * added breaking change to changelog.md * Update CHANGELOG.md * Apply suggestions from code review --------- Co-authored-by: Agriya Khetarpal <[email protected]> Co-authored-by: Arjun Verma <[email protected]>
* docs: update all_contributors.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Eric G. Kratz <[email protected]> Co-authored-by: Arjun Verma <[email protected]> Co-authored-by: Agriya Khetarpal <[email protected]>
…4011) Bumps the actions group with 1 update: [codecov/codecov-action](https://github.com/codecov/codecov-action). Updates `codecov/codecov-action` from 4.2.0 to 4.3.0 - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4.2.0...v4.3.0) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.3.5 → v0.3.7](astral-sh/ruff-pre-commit@v0.3.5...v0.3.7) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
#4183 remove autograd
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.9 → v0.4.10](astral-sh/ruff-pre-commit@v0.4.9...v0.4.10) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* docs: update all_contributors.md [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* #4120 improved error message * style: pre-commit fixes * updated test * Update tests/unit/test_parameters/test_parameter_values.py Co-authored-by: Eric G. Kratz <[email protected]> * Update pybamm/parameters/parameter_values.py Co-authored-by: Robert Timms <[email protected]> * Update pybamm/parameters/parameter_values.py Co-authored-by: Eric G. Kratz <[email protected]> --------- Co-authored-by: Ubham16 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Arjun Verma <[email protected]> Co-authored-by: Eric G. Kratz <[email protected]> Co-authored-by: Robert Timms <[email protected]>
* Update test pypi * Style fix
* Make function for handling time or reuse an existing one Fixes #4113 * style: pre-commit fixes * fixing raises RegEx Error Experiment Test * fix pre-commit error * Update pybamm/callbacks.py Co-authored-by: Eric G. Kratz <[email protected]> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Agriya Khetarpal <[email protected]> Co-authored-by: Valentin Sulzer <[email protected]> Co-authored-by: Eric G. Kratz <[email protected]>
* fix: error catch for electrode diffusivity * refactor: update diffusivity error catch and test * tests: up coverage for diffusivity name catches * Update pybamm/util.py Co-authored-by: Agriya Khetarpal <[email protected]> --------- Co-authored-by: Eric G. Kratz <[email protected]> Co-authored-by: Ferran Brosa Planella <[email protected]> Co-authored-by: Agriya Khetarpal <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Version is updated, but I did not resolve the conflicts yet. The only changes from RC2 should be the updated version and #4267 |
@agriyakhetarpal, @Saransh-cpp This should be ready for review if anyone wants to check my work. The only changes made during the conflict resolution were due to mistakes in the change log. Some updates that came after 24.1 had their entries entered into the 24.1 section. This corrects it on main for the release, and the sync PR with develop should fix it there. I created #4291 for other minor stuff that was found, but not worth holding up the release or risking more conflicts. If we find anything else during the testing process we can put it there. So far it was just some mentions of python 3.8 in the installation docs. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4289 +/- ##
==========================================
- Coverage 99.59% 99.54% -0.05%
==========================================
Files 258 288 +30
Lines 20813 21866 +1053
==========================================
+ Hits 20728 21767 +1039
- Misses 85 99 +14 ☔ View full report in Codecov by Sentry. |
This looks good to me. Note that the integration tests job is failing in the scheduled tests, while the unit tests pass because the |
@agriyakhetarpal if it helps, this is the diff between this branch and tag v24.5rc2
The diff for #4267 is
The remaining changes should mostly be the version and change log. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Sorry, I thought I already approved the PR but I notice I didn't
This will also include #4293 |
Description
PyBaMM release 24.5
This will be merged into main.