Remove time check from Jax tests to improve stability

[kratman]

Description

Jax tests checked runtime, which is inconsistent in the CI suite. This should keep the same coverage, but stop checking the runtime. Note: the changelog is also updated since that was missed in #3961

Fixes #3925

Type of change

Only test code.

• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All tests pass: $ python run-tests.py --all (or $ nox -s tests)
• The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.57%. Comparing base (78b7d25) to head (ba124aa).
Report is 4 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3963      +/-   ##
===========================================
- Coverage    99.58%   99.57%   -0.02%     
===========================================
  Files          257      257              
  Lines        21196    21198       +2     
===========================================
- Hits         21108    21107       -1     
- Misses          88       91       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kratman]

I don't see anywhere that the operator usage should have changed, so I think that coverage is outdated

[valentinsulzer]

Are these tests actually failing, or is this a "we shouldn't test times in CI"? They do test real functionality, if they are failing that indicates there may be a bug

cc @martinjrobins

[kratman]

Both

1. Time checks are not great because multiple jobs run on the same server.
2. They do end up failing randomly. Re-triggering makes them pass. This got worse since we switched to pytest

[agriyakhetarpal]

I think the failures are macOS-specific, because these tests are failing in CI but only for macOS and I have never seen them fail on Ubuntu or Windows. These take a really long time to complete on my local macOS machine too (#3948) and fail quite erratically. It makes me wonder if something is amiss upstream or a memory leak of some kind

[kratman]

Yeah I intend to keep looking into the Jax stuff, so I will try to find out if there is more going on

[valentinsulzer]

Got it. Removing makes sense in that case