Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cron schedule for PyPI publishing workflow and add cache for vcpkg dependencies #3792

Closed
wants to merge 3 commits into from
Closed

Update cron schedule for PyPI publishing workflow and add cache for vcpkg dependencies #3792

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68c3494
Update cron schedule for PyPI publishing workflow and add cache for v…
R-Yash Jan 31, 2024
c0aeb42
Merge branch 'develop' into fix_3664
arjxn-py Feb 1, 2024
7b06ec4
Added PyBaMM related environment variables in run_periodic_tests.yaml
R-Yash Feb 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/publish_pypi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ on:
release:
types: [published]
schedule:
# Run at 10 am UTC on day-of-month 1 and 15.
- cron: "0 10 1,15 * *"
# Run every Sunday at 00:00.
- cron: "0 0 * * 0"
workflow_dispatch:
inputs:
target:
Expand Down
12 changes: 11 additions & 1 deletion .github/workflows/run_periodic_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,17 @@ jobs:
if: matrix.os == 'ubuntu-latest'
run: python -m nox -s scripts

# M-series Mac Mini
- name: Cache vcpkg dependencies
if: matrix.os == 'windows-latest'
uses: actions/cache@v2
with:
path: ~/.cache/vcpkg
key: ${{ runner.os }}-vcpkg-${{ hashFiles('**/vcpkg.json') }}
restore-keys: |
${{ runner.os }}-vcpkg-


Comment on lines +133 to +142
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides this, we also need the PyBaMM-related environment variables, such as PYBAMM_USE_VCPKG_ON, CMAKE_BUILD_PARALLEL_LEVEL, and the rest present in publish_pypi.py so that setup.py can use all features of vcpkg.

After you add all of those, I would suggest triggering this workflow from this branch to test these changes (if you do it correctly, you should see a win-amd64 file being built for PyBaMM rather than the current none-any.whl).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agriyakhetarpal How can I trigger a workflow from this branch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd have to go to the actions tab on your fork then select the workflow you want to run from the left panel.
Click on the Run Workflow button >> Select the target branch >> Confirm after Clicking on the blue Run Workflow button

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arjxn-py. Also, these environment variables have been set for the entire matrix. We need these just for the Windows steps in the job. We don't have separate Windows steps, so you can create a separate step with Run integration tests on Windows and add these environment variables there (similarly for unit tests, etc.)

#M-series Mac Mini
build-apple-mseries:
if: github.repository_owner == 'pybamm-team'
needs: style
Expand Down
Loading