Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify expression of cooling terms in x-lumped thermal models #3439

Merged
merged 1 commit into from
Nov 7, 2023

simplify expression of cooling terms in x-lumped thermal models

ce8e56b
Select commit
Loading
Failed to load commit list.
Merged

simplify expression of cooling terms in x-lumped thermal models #3439

simplify expression of cooling terms in x-lumped thermal models
ce8e56b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 11, 2023 in 1s

99.58% (+0.00%) compared to bd5e240

View this Pull Request on Codecov

99.58% (+0.00%) compared to bd5e240

Details

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (bd5e240) 99.58% compared to head (ce8e56b) 99.58%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3439   +/-   ##
========================================
  Coverage    99.58%   99.58%           
========================================
  Files          256      256           
  Lines        19998    20004    +6     
========================================
+ Hits         19915    19921    +6     
  Misses          83       83           
Files Coverage Δ
pybamm/models/submodels/thermal/lumped.py 100.00% <100.00%> (ø)
...mal/pouch_cell/pouch_cell_1D_current_collectors.py 100.00% <100.00%> (ø)
...mal/pouch_cell/pouch_cell_2D_current_collectors.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.