Issue 3114 check coord

pybamm/expression_tree/independent_variable.py

@@ -5,7 +5,7 @@
 
 import pybamm
 
-KNOWN_COORD_SYS = ["cartesian", "cylindrical polar", "spherical polar"]
+KNOWN_COORD_SYS = ["cartesian", "cylindrical polar", "spherical polar","none"]
 
 
 class IndependentVariable(pybamm.Symbol):
@@ -131,6 +131,10 @@ def __init__(
             raise pybamm.DomainError(
                 "domain cannot be particle if name is '{}'".format(name)
             )
+        # check coord_sys against KNOWN_COORD_SYS
+        if coord_sys not in KNOWN_COORD_SYS:
+            raise ValueError(
+                f"Coordinate system is {coord_sys}, not in cartesian, cylindrical polar, spherical polar, none")
 
     def create_copy(self):
         """See :meth:`pybamm.Symbol.new_copy()`."""

pybamm/spatial_methods/finite_volume.py

@@ -146,11 +146,29 @@ def divergence(self, symbol, discretised_symbol, boundary_conditions):
                 out = divergence_matrix @ ((r_edges**2) * discretised_symbol)
             elif submesh.coord_sys == "cylindrical polar":
                 out = divergence_matrix @ (r_edges * discretised_symbol)
-        else:
+        elif submesh.coord_sys == "cartesian":
             out = divergence_matrix @ discretised_symbol
-
+        elif submesh.coord_sys == "none":
+            # what should we do now
+            print("It is none!")
+            out = divergence_matrix @ discretised_symbol
+        else:
+            raise ValueError(
+                f"Coordinate system is {submesh.coord_sys}, not in cartesian, cylindrical polar, spherical polar, none")
         return out
 
+    def check_coordinate_system(self, symbol):
+        """
+        Double check coordinate system
+        """
+        submesh = self.mesh[symbol.domain]
+        if submesh.coord_sys not in ["cylindrical polar", "spherical polar","cartesian","none"]:
+            raise ValueError(
+                f"Coordinate system is {submesh.coord_sys}, not in cartesian, cylindrical polar, spherical polar")
+        return
+
+
+
     def divergence_matrix(self, domains):
         """
         Divergence matrix for finite volumes in the appropriate domain.

tests/unit/test_spatial_methods/test_finite_volume/test_finite_volume.py

@@ -74,6 +74,15 @@ def test_concatenation(self):
         with self.assertRaisesRegex(pybamm.ShapeError, "child must have size n_nodes"):
             fin_vol.concatenation(edges)
 
+    def test_invalid_coordinate_system(self):
+        with self.assertRaises(ValueError):
+            pybamm.SpatialVariableEdge(
+                "x_s",
+                domain=["separator"],
+                auxiliary_domains={"secondary": "current collector"},
+                coord_sys="cartesian_2",
+            )
+
     def test_discretise_diffusivity_times_spatial_operator(self):
         # Setup mesh and discretisation
         mesh = get_mesh_for_testing()