Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant packaging dependency install #3391

Merged

Conversation

aitorres
Copy link
Contributor

@aitorres aitorres commented Oct 2, 2023

Description

Removes the packaging dependency from the explicit list of packages on two Github actions activities, since it's already included within asv[virtualenv].

Fixes #3383

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • CI change

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • [ N/A ] Code is commented, particularly in hard-to-understand areas
  • [ N/A ] Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7eb5879) 99.58% compared to head (c6907ad) 99.58%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3391   +/-   ##
========================================
  Coverage    99.58%   99.58%           
========================================
  Files          254      254           
  Lines        19817    19817           
========================================
  Hits         19734    19734           
  Misses          83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @aitorres!

@Saransh-cpp Saransh-cpp merged commit f39f767 into pybamm-team:develop Oct 2, 2023
31 of 32 checks passed
@brosaplanella
Copy link
Member

@all-contributors add @agriyakhetarpal for PR review

@allcontributors
Copy link
Contributor

@brosaplanella

I've put up a pull request to add @agriyakhetarpal! 🎉

@brosaplanella
Copy link
Member

@all-contributors add @aitorres for infrastructure

@allcontributors
Copy link
Contributor

@brosaplanella

I've put up a pull request to add @aitorres! 🎉

@Saransh-cpp
Copy link
Member

Hi Andrés

Thank you for contributing to PyBaMM under Hacktoberfest! We greatly appreciate your contributions and would like to invite you to the monthly developer meeting of PyBaMM.

PyBaMM's monthly developer meeting is a great way to engage with PyBaMM maintainers, developers, and others interested in contributing to PyBaMM. You can put forward any blockers you are facing on a particular PR, discuss potential issues you plan to work on, or learn more about PyBaMM.

Please feel free to join the meeting on 30th October through the following calendar invite - https://calendar.google.com/calendar/event?action=TEMPLATE&tmeid=MGtxNnExZWc4ZzFiOGVuOXB0c2ZtdnZ2aTlfMjAyMzEwMzBUMTYwMDAwWiBjXzE1Nzc5MGZhNTQ0Y2JmN2UzZjViNjQ5YzcwMGJhNDA0MDRhZDA0NjM0ZjkzNDBlMjU1ZTZkZWY5OWE4OWVkZGFAZw&tmsrc=c_157790fa544cbf7e3f5b649c700ba40404ad04634f9340e255e6def99a89edda%40group.calendar.google.com&scp=ALL

@brosaplanella
Copy link
Member

Hi @aitorres,

Thank you for contributing to PyBaMM under Hacktoberfest! We greatly appreciate your contributions and we would really like for you to continue engaging with PyBaMM beyond Hacktoberfest, if you wish to. Here are some ways to engage:

  • Join our Slack: our Slack workspace is, jointly with our Github pages, the main channel of communication for our community. If you are not in it yet, reply to this email and we will send an invite.
  • Monthly developer meetings: every four weeks we have our developer meetings. In these meetings, we catch up with the progress each developer has done and discuss the challenges arising. These meetings are a good place to bounce ideas and get help, as well as a good motivation to contribute to the project regularly.
  • Google Summer of Code (GSoC): PyBaMM regularly offers projects for GSoC, the open-source internship programme sponsored by Google. It provides the opportunity to work on a bigger project for an extended period of time (typically 10 weeks).
  • Maintainer training programme: regular contributors can apply to the PyBaMM maintainer training programme which, upon completion, grants the status of maintainer. The programme is flexible, and the trainee gets paired with a mentor that can suggest issues to work on, PRs to review and feedback on how to improve.

If you are interested, do not hesitate to get in touch with the team.

Cheers,

Ferran, on behalf of the PyBaMM Team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packaging listed for installation twice
4 participants