-
-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant packaging
dependency install
#3391
Remove redundant packaging
dependency install
#3391
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3391 +/- ##
========================================
Coverage 99.58% 99.58%
========================================
Files 254 254
Lines 19817 19817
========================================
Hits 19734 19734
Misses 83 83 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @aitorres!
@all-contributors add @agriyakhetarpal for PR review |
I've put up a pull request to add @agriyakhetarpal! 🎉 |
@all-contributors add @aitorres for infrastructure |
I've put up a pull request to add @aitorres! 🎉 |
Hi Andrés Thank you for contributing to PyBaMM under Hacktoberfest! We greatly appreciate your contributions and would like to invite you to the monthly developer meeting of PyBaMM. PyBaMM's monthly developer meeting is a great way to engage with PyBaMM maintainers, developers, and others interested in contributing to PyBaMM. You can put forward any blockers you are facing on a particular PR, discuss potential issues you plan to work on, or learn more about PyBaMM. Please feel free to join the meeting on 30th October through the following calendar invite - https://calendar.google.com/calendar/event?action=TEMPLATE&tmeid=MGtxNnExZWc4ZzFiOGVuOXB0c2ZtdnZ2aTlfMjAyMzEwMzBUMTYwMDAwWiBjXzE1Nzc5MGZhNTQ0Y2JmN2UzZjViNjQ5YzcwMGJhNDA0MDRhZDA0NjM0ZjkzNDBlMjU1ZTZkZWY5OWE4OWVkZGFAZw&tmsrc=c_157790fa544cbf7e3f5b649c700ba40404ad04634f9340e255e6def99a89edda%40group.calendar.google.com&scp=ALL |
Hi @aitorres, Thank you for contributing to PyBaMM under Hacktoberfest! We greatly appreciate your contributions and we would really like for you to continue engaging with PyBaMM beyond Hacktoberfest, if you wish to. Here are some ways to engage:
If you are interested, do not hesitate to get in touch with the team. Cheers, Ferran, on behalf of the PyBaMM Team |
Description
Removes the
packaging
dependency from the explicit list of packages on two Github actions activities, since it's already included withinasv[virtualenv]
.Fixes #3383
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: