Bug fix: Improve cracking integration tests and examples on M-series hardware

[kratman]

Description

On apple m-series hardware, the cracking simulations fail in the examples and integration tests. The error message suggested adjusting dt_max, but I did not get that working. What worked instead was adjusting the size of the mesh used in the simulation. This change does not address the root cause of the issue, but can make the tests run. Having failing tests makes it difficult to see if new changes are causing issues.

Original:

var_pts = {
    "x_n": 20,  # negative electrode
    "x_s": 20,  # separator 
    "x_p": 20,  # positive electrode
    "r_n": 30,  # negative particle
    "r_p": 30,  # positive particle
}

New:

var_pts = {
    "x_n": 20,  # negative electrode
    "x_s": 20,  # separator 
    "x_p": 20,  # positive electrode
    "r_n": 26,  # negative particle
    "r_p": 26,  # positive particle
}

Related #3140

Type of change

Minor adjustment to the integration tests and examples to improve compatibility for Mac.

• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All tests pass: $ python run-tests.py --all (or $ nox -s tests)
• The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d67b009) 99.58% compared to head (66742b2) 99.58%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3372   +/-   ##
========================================
  Coverage    99.58%   99.58%           
========================================
  Files          256      256           
  Lines        19998    19998           
========================================
  Hits         19915    19915           
  Misses          83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kratman]

Lychee error is corrected in #3373

[BradyPlanden]

Looks great, thanks! It seems that the Lychee workflow is still causing problems, but that doesn't appear to be caused by the changes in this pull. It looks like there is a conflict to resolve, but as discussed in the dev meeting let's merge this fix and keep #3140 open.

[kratman]

Looks great, thanks! It seems that the Lychee workflow is still causing problems, but that doesn't appear to be caused by the changes in this pull. It looks like there is a conflict to resolve, but as discussed in the dev meeting let's merge this fix and keep #3140 open.

Yeah lychee was unrelated to this change. I will fix the conflict so it can be merged.

[kratman]

@BradyPlanden Should be good to go after the tests pass. It all worked locally after the merge