Bug fix: Replace prop_cycler with Cycler() #3349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
kratman
commented
Sep 16, 2023
There was a problem hiding this comment.
The changes in the notebook are the same in this file. The notebook and script share a lot of the same code.
kratman
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #3349 +/- ##
========================================
Coverage 99.55% 99.55%
========================================
Files 253 253
Lines 19553 19553
========================================
Hits 19466 19466
Misses 87 87 ☔ View full report in Codecov by Sentry. |
|
@all-contributors please add @kratman for bug fixes |
|
I've put up a pull request to add @kratman! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Matplotlib updated to 3.8 on Friday. Since then the line
causes the following error:
I have replaced the prop_cycler with a cycler object and configured it with a generic color order. This was the most minimal change I could think of to resolve the issue. I am open to suggestions for a specific color set or I can just remove the explicit cycler and let matplotlib handle the colors itself. The latter also resolves the issue.
Fixes #3346
Type of change
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all(or$ nox -s tests)$ python run-tests.py --doctest(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick(or$ nox -s quick).Further checks: