Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run nox -s scripts in the scheduled tests #3345

Merged

Conversation

agriyakhetarpal
Copy link
Member

Description

This PR adds a job step for testing the example scripts nightly (we weren't testing the example scripts in the scheduled tests workflow after #3264 and #3279)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (7cba890) 99.55% compared to head (e4cb2a4) 99.60%.
Report is 29 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3345      +/-   ##
===========================================
+ Coverage    99.55%   99.60%   +0.05%     
===========================================
  Files          253      253              
  Lines        19553    19546       -7     
===========================================
+ Hits         19466    19469       +3     
+ Misses          87       77      -10     
Files Changed Coverage Δ
pybamm/solvers/solution.py 100.00% <ø> (ø)
pybamm/experiment/experiment.py 100.00% <100.00%> (ø)
pybamm/parameters/bpx.py 99.49% <100.00%> (+4.73%) ⬆️
pybamm/simulation.py 100.00% <100.00%> (ø)
pybamm/step/_steps_util.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @agriyakhetarpal! Could you merge develop once to fix the failing CI?

@Saransh-cpp Saransh-cpp merged commit 9da1ddf into pybamm-team:develop Sep 19, 2023
31 of 32 checks passed
@agriyakhetarpal agriyakhetarpal deleted the scheduled-scripts-fix branch September 19, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants