Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3323 - electrode thickness change [m] #3329

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Issue 3323 - electrode thickness change [m] #3329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
096f0b3
#3323 fix electrode thickness change [m]
Sep 13, 2023
c3d6355
#3323 regenerating figures in the tutorial with new code
Sep 13, 2023
e8b56ae
#3329 Update CHANGELOG.md
bobonice Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
- Numpy functions now work with PyBaMM symbols (e.g. `np.exp(pybamm.Symbol("a"))` returns `pybamm.Exp(pybamm.Symbol("a"))`). This means that parameter functions can be specified using numpy functions instead of pybamm functions. Additionally, combining numpy arrays with pybamm objects now works (the numpy array is converted to a pybamm array) ([#3205](https://github.com/pybamm-team/PyBaMM/pull/3205))

## Bug fixes

- Fixed a bug that caused incorrect results of “{Domain} electrode thickness change [m]” due to the absence of dimension for the variable `electrode_thickness_change`([#3329](https://github.com/pybamm-team/PyBaMM/pull/3329)).
- Fixed a bug that occured in `check_ys_are_not_too_large` when trying to reference `y-slice` where the referenced variable was not a `pybamm.StateVector` ([#3313](https://github.com/pybamm-team/PyBaMM/pull/3313)
- Fixed a bug with `_Heaviside._evaluate_for_shape` which meant some expressions involving heaviside function and subtractions did not work ([#3306](https://github.com/pybamm-team/PyBaMM/pull/3306))
- The `OneDimensionalX` thermal model has been updated to account for edge/tab cooling and account for the current collector volumetric heat capacity. It now gives the correct behaviour compared with a lumped model with the correct total heat transfer coefficient and surface area for cooling. ([#3042](https://github.com/pybamm-team/PyBaMM/pull/3042))
Expand Down
26 changes: 16 additions & 10 deletions docs/source/examples/notebooks/models/Validating_mechanical_models_Enertech_DFN.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion pybamm/models/submodels/particle_mechanics/base_mechanics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,13 @@ def _get_mechanical_results(self, variables):
c_0 = domain_param.c_0
E0 = domain_param.E
nu = domain_param.nu
L0 = domain_param.L
sto_init = pybamm.r_average(domain_param.prim.c_init / domain_param.prim.c_max)
v_change = pybamm.x_average(
eps_s * domain_param.prim.t_change(sto_rav)
) - pybamm.x_average(eps_s * domain_param.prim.t_change(sto_init))

electrode_thickness_change = self.param.n_electrodes_parallel * v_change
electrode_thickness_change = self.param.n_electrodes_parallel * v_change * L0
# Ai2019 eq [10]
disp_surf = Omega * R0 / 3 * (c_s_rav - c_0)
# c0 reference concentration for no deformation
Expand Down
Loading