Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3298 heaviside shape #3306

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Issue 3298 heaviside shape #3306

merged 3 commits into from
Sep 4, 2023

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented Sep 3, 2023

Description

Fixes shape error with Heaviside

Fixes #3298

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@rtimms rtimms requested a review from brosaplanella September 3, 2023 21:10
@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (840fb13) 99.70% compared to head (460e540) 99.70%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3306   +/-   ##
========================================
  Coverage    99.70%   99.70%           
========================================
  Files          248      248           
  Lines        18890    18894    +4     
========================================
+ Hits         18835    18839    +4     
  Misses          55       55           
Files Changed Coverage Δ
pybamm/expression_tree/binary_operators.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@rtimms rtimms merged commit ea4cc7b into develop Sep 4, 2023
29 of 32 checks passed
@rtimms rtimms deleted the issue-3298-heaviside-shape branch September 4, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subtraction with bool in expressions fails
2 participants