change model's name

pybamm-team · Sep 24, 2024 · 2ac3484 · 2ac3484
1 parent 07b1bf3
commit 2ac3484
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/pybamm/models/full_battery_models/base_battery_model.py b/src/pybamm/models/full_battery_models/base_battery_model.py
@@ -302,7 +302,7 @@ def __init__(self, extra_options):
                 "interstitial-diffusion limited",
                 "ec reaction limited",
                 "ec reaction limited (asymmetric)",
-                "Kolzenberg2020",
+                "VonKolzenberg2020",
                 "tunnelling limited",
             ],
             "SEI film resistance": ["none", "distributed", "average"],

diff --git a/src/pybamm/models/submodels/interface/sei/sei_growth.py b/src/pybamm/models/submodels/interface/sei/sei_growth.py
@@ -147,7 +147,7 @@ def get_coupled_variables(self, variables):
                 * pybamm.exp(-phase_param.beta_tunnelling * L_sei_inner)
             )
 
-        elif SEI_option == "Kolzenberg2020":
+        elif SEI_option == "VonKolzenberg2020":
             # Equation 19 in
             # von Kolzenberg L, Latz A, Horstmann B.
             # Solid electrolyte interphase during battery cycling:

diff --git a/tests/unit/test_models/test_full_battery_models/test_base_battery_model.py b/tests/unit/test_models/test_full_battery_models/test_base_battery_model.py
@@ -41,7 +41,8 @@
 'particle phases': '1' (possible: ['1', '2'])
 'particle shape': 'spherical' (possible: ['spherical', 'no particles'])
 'particle size': 'single' (possible: ['single', 'distribution'])
-'SEI': 'none' (possible: ['none', 'constant', 'reaction limited', 'reaction limited (asymmetric)', 'solvent-diffusion limited', 'electron-migration limited', 'interstitial-diffusion limited', 'ec reaction limited', 'ec reaction limited (asymmetric)'])
+'SEI': 'none' (possible: ['none', 'constant', 'reaction limited', 'reaction limited (asymmetric)', 'solvent-diffusion limited', 'electron-migration limited', 'interstitial-diffusion limited', 'ec reaction limited', 'ec reaction limited (asymmetric)', 'VonKolzenberg2020',
+                'tunnelling limited'])
 'SEI film resistance': 'none' (possible: ['none', 'distributed', 'average'])
 'SEI on cracks': 'false' (possible: ['false', 'true'])
 'SEI porosity change': 'false' (possible: ['false', 'true'])