begin working on tests

pybamm-team · Dec 12, 2024 · 1c82b6c · 1c82b6c
1 parent d468be4
commit 1c82b6c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/src/pybamm/parameters/parameter_values.py b/src/pybamm/parameters/parameter_values.py
@@ -604,12 +604,12 @@ def process_geometry(self, geometry):
 
         def process_and_check(sym):
             new_sym = self.process_symbol(sym)
-            if not isinstance(new_sym, pybamm.Scalar) and not isinstance(
-                new_sym, pybamm.InputParameter
-            ):
-                raise ValueError(
-                    "Geometry parameters must be Scalars or InputParameters after parameter processing"
-                )
+            #if not isinstance(new_sym, pybamm.Scalar) and not isinstance(
+            #    new_sym, pybamm.InputParameter
+            #):
+            #    raise ValueError(
+            #        "Geometry parameters must be Scalars or InputParameters after parameter processing"
+            #    )
             return new_sym
 
         for domain in geometry:

diff --git a/tests/unit/test_meshes/test_one_dimensional_submesh.py b/tests/unit/test_meshes/test_one_dimensional_submesh.py
@@ -94,6 +94,10 @@ def test_exceptions(self):
         lims = {"a": 1, "b": 2}
         with pytest.raises(pybamm.GeometryError):
             pybamm.SymbolicUniform1DSubMesh(lims, None)
+        tabs = {"negative": {"z_centre": 0}, "positive": {"z_centre": 1}}
+
+        with pytest.raises(NotImplementedError):
+            pybamm.SymbolicUniform1DSubMesh(lims, 20, tabs=tabs)
 
     def test_symmetric_mesh_creation_no_parameters(self, r, geometry):
         submesh_types = {"negative particle": pybamm.Uniform1DSubMesh}