rob's suggestions

pybamm-team · Dec 5, 2023 · 0beaff2 · 0beaff2
1 parent 2a05c1c
commit 0beaff2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/pybamm/models/submodels/thermal/pouch_cell/x_full.py b/pybamm/models/submodels/thermal/pouch_cell/x_full.py
@@ -180,4 +180,8 @@ def set_initial_conditions(self, variables):
         T_cn = variables["Negative current collector temperature [K]"]
         T_cp = variables["Positive current collector temperature [K]"]
         T_init = self.param.T_init
-        self.initial_conditions = {T_cn: T_init, T: T_init, T_cp: T_init}
+        self.initial_conditions = {
+            T_cn: pybamm.boundary_value(T_init, "left"),
+            T: T_init,
+            T_cp: pybamm.boundary_value(T_init, "right"),
+        }
diff --git a/pybamm/parameters/thermal_parameters.py b/pybamm/parameters/thermal_parameters.py
@@ -31,9 +31,12 @@ def __init__(self, options=None):
 
     def _set_parameters(self):
         """Defines the dimensional parameters"""
-        for domain, params in self.domain_params.items():
-            #params._domain = domain  # Set _domain attribute
-            params._set_parameters()
+        for domain in self.domain_params.values():
+            domain._set_parameters()
+
+       # for domain, params in self.domain_params.items():
+        #    #params._domain = domain  # Set _domain attribute
+        #    params._set_parameters()
 
         # Reference temperature
         self.T_ref = pybamm.Parameter("Reference temperature [K]")