DDF patch 4 #681
Merged
DDF patch 4 #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed changing the overlay color for the case where plot_marker_radius_pixels is None
Update digital_dark_field.py
Basic radial functions added
|
Thanks Ben, |
|
Sounds good, thanks Ian. We've just released the code with your recent PRs
included (v0.14.17, up on pip now, should be up on conda by the end of the
day or tomorrow). We can get your additional functions included in the
next version :)
…On Thu, Sep 5, 2024 at 2:20 PM maclariz ***@***.***> wrote:
Thanks Ben,
A few further functions using polar definitions will follow in due course,
but not quite in final form. I'm now taking a few days off so will get back
to it in due course.
—
Reply to this email directly, view it on GitHub
<#681 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQYYNIQ445WCL4Y625WFM3ZVCOFZAVCNFSM6AAAAABNU6AAA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZSGM3TAOBXGY>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, as discussed, I added some extra functionality to pointslist_to_array so it now adds qr and qphi by default, although this can be turned off
I then also added the first radial imaging function, DDF_radial_image
Hope you like them