Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A little Ruff around the edges #667

Open
wants to merge 33 commits into
base: dev
Choose a base branch
from
Open

A little Ruff around the edges #667

wants to merge 33 commits into from

Conversation

alex-rakowski
Copy link
Collaborator

This PR changes the linter for flake8 to Ruff. We should agree on how exactly we want the linter configured before squashing and merging

  • adds ruff.toml to configure ruff
  • adds ruff.yml to configure and run ruff on only changed files in Github Actions
  • updates pre-commit.yml to run black and ruff and removes flake8
  • removes various flake8 config and Github Action files.

@alex-rakowski
chore: Add Ruff GitHub Actions workflow and update pre-commit configu…
bcbe191 
…ration
@alex-rakowski
trying to add ruff only on changed files
b88c5b8
@alex-rakowski
bumping version
f53ff3d
@alex-rakowski
trying to trigger CI failure
88e79f0
@alex-rakowski
updating action
7191c4d
@alex-rakowski
another attempt
7fc8f76
@alex-rakowski
another another test
2105dec
@alex-rakowski
reverting the change
909ddfa
@alex-rakowski
updating to ignore to see if it passes CI
3338ab4
@alex-rakowski
adding rule update
4ec5a92
@alex-rakowski
change name
90d77a2
@alex-rakowski
Add GitHub Actions workflow for running Ruff on changed files
2906376
@alex-rakowski
adding error to trigger CI
328903e
@alex-rakowski
reducing ignored ruff rules
8b6ebfa
@alex-rakowski
trying again
9077264
@alex-rakowski
trying again
ecef76e
@alex-rakowski
adding another erroed file
4b6caf6
@alex-rakowski
adding new yml
b46ac14
@alex-rakowski
adding errored file
79d8e6f
@alex-rakowski
adding multiple errored files
ae64d83
@alex-rakowski
removing errored files
08dfc4e
@alex-rakowski
removing ruff formatter from pre commit
32d9fd3
@alex-rakowski
updating pre-commit
d5de04f
@alex-rakowski
updating ruff.toml
150422e
@alex-rakowski
changing name of rust GHA
22386a0
@alex-rakowski
removing flake8 runs
13c1be8
@alex-rakowski
typo name
73a157e
@alex-rakowski
Rename GitHub Actions workflow to "Ruff Check"
b30f023
@alex-rakowski
Add conditional check for changed files in GitHub Actions workflow
1442fd9
@alex-rakowski
adding errored file
3e87930
@alex-rakowski alex-rakowski requested a review from bsavitzky July 12, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsavitzky bsavitzky Awaiting requested review from bsavitzky

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alex-rakowski