-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This winter solstice, we celebrate the wonders of the parallax effect #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still needs testing!
Adding probe position correction to parallax
Correctly set scan units when `force_scan_sampling` is used
sezelt
approved these changes
Jan 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good, mostly just highlighted a few missing/incomplete docstring things
Co-authored-by: Steve Zeltmann <[email protected]>
Co-authored-by: Steve Zeltmann <[email protected]>
Co-authored-by: Steve Zeltmann <[email protected]>
Co-authored-by: Steve Zeltmann <[email protected]>
Co-authored-by: Steve Zeltmann <[email protected]>
Co-authored-by: Steve Zeltmann <[email protected]>
Co-authored-by: Steve Zeltmann <[email protected]>
bsavitzky
pushed a commit
to bsavitzky/py4DSTEM
that referenced
this pull request
Mar 12, 2024
This winter solstice, we celebrate the wonders of the parallax effect Former-commit-id: b167640
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various updates and new functionality to parallax.
Notably:
Improvements to aberration fitting:
force_rotation_deg
Improvements to upsampling interpolation methods
Probe position refinement
Fixed-step gradient descent or "checker-boarding" algorithm with
initial_step_size
, decreasing geometrically bystep_size_factor
up to a minimum step ofmin_step_size
.Probe-position refinement results can be inspected using