Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add robust fitting back to fit_origin #552

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Conversation

sezelt
Copy link
Member

@sezelt sezelt commented Nov 1, 2023

Fixes #548

Copy link
Member

@bsavitzky bsavitzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @sezelt. Not sure how things wound up in this strange state.

There will be conflicts with the edits I made in my GTO branch to add the masking functionality correctly back in to this method, but I'll just pull from dev and handle them locally before PRing those changes. I'll likely modify the arguments at that point as well (mask_check_data is nutso), so small modifications to user-side code may be necessary then, but these should be small things.

Lmk if you still need the masking mods given this PR. Since I'll need to handle conflicts before I can push that stuff, I can try to get to that sooner if you need it or a bit later if not.

@bsavitzky bsavitzky merged commit 02c419a into py4dstem:dev Nov 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several arguments to BraggVectors.fit_origin are ignored
2 participants