adding "sphinx_rtd_theme" to conf.py

[alex-rakowski]

looks like this needed to be added to the extensions in conf.py

https://sphinx-rtd-theme.readthedocs.io/en/stable/installing.html

[sezelt]

Since this adds a dependency I think we should get a vibecheck from @bsavitzky.

Alternatively, do you think it's possible to make this an optional dependency, like py4dstem[docs] and have the readthedocs builder install that option? That way ordinary installs don't require sphinx_rtd_theme.

[alex-rakowski]

I moved the dependency from the setup.py and put it in the docs requirement.txt instead. If we wanted a pip install py4DSTEM[docs] method instead we'd have to alter setup.py and .readthedocs.yml with

python:
  install:
     - method: pip
       path: .
       extra_requirements:
          - docs

[sezelt]

Having the requirement within the docs setup file seems like the best solution, since it doesn't interfere with the requirements for installing and running.
Thanks

[bsavitzky]

Thanks for working this out Steve and Alex! Agreed, this is the correct solution :)

…

On Fri, Oct 6, 2023, 8:35 PM Steve Zeltmann ***@***.***> wrote: Merged #531 <#531> into dev. — Reply to this email directly, view it on GitHub <#531 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQYYNJLQYNQZV52LJY5H3DX6BMQHAVCNFSM6AAAAAA5VS42V6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQGU3TSMJSGM3TENA> . You are receiving this because you were mentioned.Message ID: ***@***.***>