Updates to Android DatePickerPlugin #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oc bar : true (android)
…gap-iphone/commit/5544b2a0664ae2714ec1df2b6e16aa97d3cfa9bc the BarcodePlugin stopped working. I've taken a note from the InAppPurchaseManager plugin and created a plugin map with proper disposal of callback methods.
to the Shopify API from Javascript
Initial commit of Phonegap plugin for Android to enable Torch functionality
facebook plugin implementation
Native Android's Date and Time picker plugin
ChildBrowser and Xcode4
Updated EmailComposer to 1.0
…that function defined in some of your other code or something?
The Xcode analyser was complaining about some logic issues and uninitialised values. Turned out to be pretty simple to clean up.
… cleaning up code.
|
Is this still valid? or has it already been merged via the phonegap fork? |
|
It has not been merged into the phonegap fork. I'm not actively developing in phonegap anymore so I noticed that there was a phonegap fork, but haven't tried to merge this there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android datepicker plugin
-Knows how to display a 'datetime' picker (really just a datepicker then a timepicker).
-Returns a javascript Date object instead of objects with different properties based on what has been called.
-More in line with iOS timepicker plugin.