Skip to content

Commit

Permalink
Drop typelevel-prelude dependency
Browse files Browse the repository at this point in the history
We aren't actually using anything provided by typelevel-prelude;
instead, we're only using its re-exports. Dropping the dependency and
importing RLProxy and the Union class from where they are defined means
that we have fewer dependencies to worry about, so version
incompatibilities are less likely to occur.

I'd suggest releasing this as a patch-level change; previously we have
recommended releasing changes in which dependencies have been dropped as
major-level, because it can break downstream libraries if they are
relying on the presence of that dependency, but I have come to believe
that this policy is worse since it results in far too many unnecessary
major version bumps, and downstream libraries depending on a particular
transitive dependency but not declaring that dependency are arguably
broken anyway.
  • Loading branch information
hdgarrood committed May 31, 2019
1 parent 05f0cf2 commit bfb942e
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion bower.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
"purescript-functions": "^4.0.0",
"purescript-nullable": "^4.1.0",
"purescript-record": "^1.0.0",
"purescript-typelevel-prelude": "^3.0.0",
"purescript-unsafe-coerce": "^4.0.0",
"purescript-web-dom": "^1.0.0",
"purescript-web-html": "^1.0.0",
Expand Down
2 changes: 1 addition & 1 deletion src/React/Basic.purs
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import Data.Function.Uncurried (Fn2, mkFn2, runFn2)
import Data.Nullable (Nullable, notNull, null)
import Effect (Effect)
import Effect.Uncurried (EffectFn3, runEffectFn3)
import Type.Row (class Union)
import Prim.Row (class Union)

-- | `ComponentSpec` represents a React-Basic component implementation.
-- |
Expand Down
2 changes: 1 addition & 1 deletion src/React/Basic/Events.purs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import Effect.Uncurried (EffectFn1, mkEffectFn1)
import Prim.Row as Row
import Prim.RowList (kind RowList, class RowToList, Cons, Nil)
import Record (delete, get, insert)
import Type.Row (RLProxy(..))
import Type.Data.RowList (RLProxy(..))

-- | An event handler, which receives a `SyntheticEvent` and performs some
-- | effects in return.
Expand Down

0 comments on commit bfb942e

Please sign in to comment.