Merge pull request #55 from Hi-Angel/support-dialog-onclose

DOM: support `onClose` event in `dialog` element
purescript-react · Nov 8, 2024 · a0ed953 · a0ed953
2 parents b93b156 + 19b0082
commit a0ed953
Show file tree

Hide file tree

Showing 6 changed files with 28 additions and 16 deletions.
diff --git a/codegen/consts.js b/codegen/consts.js
@@ -67,6 +67,7 @@ module.exports.types = {
   "onCanPlayThrough": "EventHandler",
   "onChange": "EventHandler",
   "onClick": "EventHandler",
+  "onClose": "EventHandler",
   "onCompositionEnd": "EventHandler",
   "onCompositionStart": "EventHandler",
   "onCompositionUpdate": "EventHandler",

diff --git a/codegen/index.js b/codegen/index.js
@@ -5,10 +5,15 @@ const htmlGenFile = "../src/React/Basic/DOM/Generated.purs";
 const htmlSimplifiedGenFile = "../src/React/Basic/DOM/Simplified/Generated.purs";
 const svgGenFile = "../src/React/Basic/DOM/SVG.purs";
 
-const htmlHeader = `-- | ----------------------------------------
+const warningHeader = `-- | ------------------------------------------------------------
 -- | THIS FILE IS GENERATED -- DO NOT EDIT IT
--- | ----------------------------------------
+-- | Instead edit files under 'codegen/' dir and regenerate with:
+-- |     npm install
+-- |     node ./index.js
+-- | ------------------------------------------------------------
+`;
 
+const htmlHeader = `${warningHeader}
 module React.Basic.DOM.Generated where
 
 import Data.Nullable (Nullable)
@@ -23,10 +28,7 @@ import Web.DOM (Node)
 
 `;
 
-const simplifiedHtmlHeader = `-- | ----------------------------------------
--- | THIS FILE IS GENERATED -- DO NOT EDIT IT
--- | ----------------------------------------
-
+const simplifiedHtmlHeader = `${warningHeader}
 module React.Basic.DOM.Simplified.Generated where
 
 import Data.Nullable (Nullable)
@@ -55,10 +57,7 @@ const propType = (e, p) => {
   }
 }
 
-const svgHeader = `-- | ----------------------------------------
--- | THIS FILE IS GENERATED -- DO NOT EDIT IT
--- | ----------------------------------------
-
+const svgHeader = `${warningHeader}
 module React.Basic.DOM.SVG where
 
 import Data.Nullable (Nullable)

diff --git a/codegen/react-html-attributes.json b/codegen/react-html-attributes.json
@@ -233,6 +233,7 @@
     "title"
   ],
   "dialog": [
+    "onClose",
     "open"
   ],
   "embed": [

diff --git a/src/React/Basic/DOM/Generated.purs b/src/React/Basic/DOM/Generated.purs
@@ -1,6 +1,9 @@
--- | ----------------------------------------
+-- | ------------------------------------------------------------
 -- | THIS FILE IS GENERATED -- DO NOT EDIT IT
--- | ----------------------------------------
+-- | Instead edit files under 'codegen/' dir and regenerate with:
+-- |     npm install
+-- |     node ./index.js
+-- | ------------------------------------------------------------
 
 module React.Basic.DOM.Generated where
 
@@ -4310,6 +4313,7 @@ type Props_dialog =
   , onAnimationStart :: EventHandler
   , onBlur :: EventHandler
   , onClick :: EventHandler
+  , onClose :: EventHandler
   , onCompositionEnd :: EventHandler
   , onCompositionStart :: EventHandler
   , onCompositionUpdate :: EventHandler

diff --git a/src/React/Basic/DOM/SVG.purs b/src/React/Basic/DOM/SVG.purs
@@ -1,6 +1,9 @@
--- | ----------------------------------------
+-- | ------------------------------------------------------------
 -- | THIS FILE IS GENERATED -- DO NOT EDIT IT
--- | ----------------------------------------
+-- | Instead edit files under 'codegen/' dir and regenerate with:
+-- |     npm install
+-- |     node ./index.js
+-- | ------------------------------------------------------------
 
 module React.Basic.DOM.SVG where
 

diff --git a/src/React/Basic/DOM/Simplified/Generated.purs b/src/React/Basic/DOM/Simplified/Generated.purs
@@ -1,6 +1,9 @@
--- | ----------------------------------------
+-- | ------------------------------------------------------------
 -- | THIS FILE IS GENERATED -- DO NOT EDIT IT
--- | ----------------------------------------
+-- | Instead edit files under 'codegen/' dir and regenerate with:
+-- |     npm install
+-- |     node ./index.js
+-- | ------------------------------------------------------------
 
 module React.Basic.DOM.Simplified.Generated where
 
@@ -3884,6 +3887,7 @@ type Props_dialog =
   , onAnimationStart :: EventHandler
   , onBlur :: EventHandler
   , onClick :: EventHandler
+  , onClose :: EventHandler
   , onCompositionEnd :: EventHandler
   , onCompositionStart :: EventHandler
   , onCompositionUpdate :: EventHandler
-Original file line number
+Diff line change
@@ Expand Up / @@ -233,6 +233,7 @@ @@
         "title"
       ],
       "dialog": [
+        "onClose",
         "open"
       ],
       "embed": [
@@ Expand Down @@