Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scripts/removeAnchors.sh on Mac #398

Closed
wants to merge 1 commit into from

Conversation

cblp
Copy link

@cblp cblp commented Nov 13, 2021

No description provided.

@keithlayne
Copy link

Neither the built-in find nor GNU find seem to recognize that flag on my Mac.

@cblp
Copy link
Author

cblp commented Nov 14, 2021

It's strange, I see the same options as in https://www.unix.com/man-page/FreeBSD/1/find/

MacOS 11.6

@stackcats
Copy link

I can use this version on my Mac.

@keithlayne
Copy link

Must have been user error on my part, confirm it works with /usr/bin/find on my mac. But GNU find doesn't recognize that flag, so it's not going to work on linux.

I don't think anyone should have to worry about this - I have another suggestion in #396.

@milesfrain
Copy link
Member

Unfortunately, find -E doesn't work on linux.

We could add a conditional in that script to check for machine type.

We should also add a CI target for Mac. PR's welcome for that addition.

I also like some of the ideas proposed in #396.

@cblp cblp closed this Nov 22, 2021
@cblp cblp deleted the removeAnchors branch November 22, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants