-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FFI for json
#11
Merged
Merged
Add FFI for json
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `JArray`
Various updates
`Path` works better this way for building up error paths after the fact rather than having to push them down as we go. Makes some of the new ops easier to implement too.
Rework `Path`, add some variations for `Gen`
Allows writing a faster decoder for optional values because you don't have to call `case_` twice to first peel off the null case and then do the actual decoding for the value.
Add `isNull` predicate
Ah this is failing because of a patch missing from |
Needs purescm/purescm#236 |
f-f
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds FFI definitions for
core/json
along with a JSON parser and printer. Printer doesn't support pretty printing yet.Doing a subtree merge from the upstream json repo creates a bunch of commits that have already been merged. I guess this is ok as this is a merge commit.