Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FFI for json #11

Merged
merged 29 commits into from
May 21, 2024
Merged

Add FFI for json #11

merged 29 commits into from
May 21, 2024

Conversation

anttih
Copy link
Contributor

@anttih anttih commented May 20, 2024

Adds FFI definitions for core/json along with a JSON parser and printer. Printer doesn't support pretty printing yet.

Doing a subtree merge from the upstream json repo creates a bunch of commits that have already been merged. I guess this is ok as this is a merge commit.

garyb and others added 29 commits March 13, 2019 02:52
`Path` works better this way for building up error paths after the fact rather than having to push them down as we go. Makes some of the new ops easier to implement too.
Rework `Path`, add some variations for `Gen`
Allows writing a faster decoder for optional values because you don't
have to call `case_` twice to first peel off the null case and then do
the actual decoding for the value.
@anttih
Copy link
Contributor Author

anttih commented May 20, 2024

Ah this is failing because of a patch missing from purescm.

@anttih
Copy link
Contributor Author

anttih commented May 20, 2024

Needs purescm/purescm#236

Copy link
Contributor

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@anttih anttih merged commit 48119e8 into purescm:master May 21, 2024
1 check passed
@anttih anttih deleted the json-ffi-v2 branch May 21, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants