(maint) Fix dynamic-scope resource defaults #356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, many classes in the puppetdb module overrode
the
Ini_setting
type with their own (different) parameters & values,resulting in a Russian roulette of dynamically-scoped default parameters
wherever
ini_setting
is used.This patch converts all dynamically-scoped parameter "defaults" for the
Ini_settings type to use Hash-bashed attributes and local resource
defaults instead.