-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Litmus from Gemfile #738
Conversation
We do not use Litmus for tests and its dependencies are causing issues in our CI pipeline. This commit removes Litmus from the Gemfile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nice!
Edit: Isn't this coming from pdk? And the next time |
We couldn't find a way to exclude just a single gem from pdk update, e.g. puppetlabs/puppetlabs-host_core#56 (comment) |
ah okay, makes sense. About the CI issues: We fixed some CentOS 9 issues in voxpupuli/beaker-docker#148 , but that broke other jobs. Current idea to fix it is voxpupuli/beaker-docker#151 |
Thanks for the pointers @bastelfreak but I think (?) these failures may be due to the apt module?
Specifically this change puppetlabs/puppetlabs-apt@1e1baad#diff-792ade83ea45b5c6696875678e6e7cc52f4a105db6ed4d8b6f2933ec5d7d6f3bR25-R26 |
Yes, that needs to be fixed at
|
The bug in beaker-docker got fixed (see https://github.com/puppetlabs/puppetlabs-puppet_agent/actions/runs/11938696618/job/33277527843?pr=738 for the failures). We just published 2.5.2 |
Superseded by #740 |
We do not use Litmus for tests and its dependencies are causing issues in our CI pipeline. This commit removes Litmus from the Gemfile.