Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Litmus from Gemfile #738

Closed
wants to merge 1 commit into from

Conversation

joshcooper
Copy link
Contributor

We do not use Litmus for tests and its dependencies are causing issues in our CI pipeline. This commit removes Litmus from the Gemfile.

We do not use Litmus for tests and its dependencies are causing issues
in our CI pipeline. This commit removes Litmus from the Gemfile.
@joshcooper joshcooper requested review from bastelfreak and a team as code owners November 20, 2024 17:32
Copy link
Collaborator

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice!

@bastelfreak
Copy link
Collaborator

Edit: Isn't this coming from pdk? And the next time pdk update is executed, the gem will be readded?

@joshcooper
Copy link
Contributor Author

We couldn't find a way to exclude just a single gem from pdk update, e.g. puppetlabs/puppetlabs-host_core#56 (comment)

@bastelfreak
Copy link
Collaborator

ah okay, makes sense.

About the CI issues: We fixed some CentOS 9 issues in voxpupuli/beaker-docker#148 , but that broke other jobs. Current idea to fix it is voxpupuli/beaker-docker#151

@joshcooper
Copy link
Contributor Author

joshcooper commented Nov 20, 2024

Thanks for the pointers @bastelfreak but I think (?) these failures may be due to the apt module?

     # --- Caused by: ---
     # Puppet::ParseError:
     #   Apt::Setting[list-puppet-enterprise-installer]: parameter 'content' expects a value of type Undef or String[1], got String

Specifically this change puppetlabs/puppetlabs-apt@1e1baad#diff-792ade83ea45b5c6696875678e6e7cc52f4a105db6ed4d8b6f2933ec5d7d6f3bR25-R26

@kenyon
Copy link
Contributor

kenyon commented Nov 20, 2024

Thanks for the pointers @bastelfreak but I think (?) these failures may be due to the apt module?

     # --- Caused by: ---
     # Puppet::ParseError:
     #   Apt::Setting[list-puppet-enterprise-installer]: parameter 'content' expects a value of type Undef or String[1], got String

Specifically this change puppetlabs/puppetlabs-apt@1e1baad#diff-792ade83ea45b5c6696875678e6e7cc52f4a105db6ed4d8b6f2933ec5d7d6f3bR25-R26

Yes, that needs to be fixed at

and other places in that file, similar to this fix: https://github.com/voxpupuli/puppet-rabbitmq/pull/1025/files#diff-01e9ff00dcf670b76d375536642dcfc62cc0efa6d796820d20b87fe721d9ed7e

@bastelfreak
Copy link
Collaborator

The bug in beaker-docker got fixed (see https://github.com/puppetlabs/puppetlabs-puppet_agent/actions/runs/11938696618/job/33277527843?pr=738 for the failures). We just published 2.5.2

@joshcooper
Copy link
Contributor Author

Superseded by #740

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants