Support for debian absolute_path to be dynamic #660
Conversation
…for Debian systems when using absolute_path
|
|
|
Closed and reopened to kick GH checks |
|
Thoughts @kenyon @bastelfreak ? |
There was a problem hiding this comment.
Thoughts @kenyon @bastelfreak ?
I don't use absolute_source, but I think the logic in this change makes sense.
I guess absolute_path in the PR title and description is a typo for absolute_source. Not sure what the "be dynamic" means. I'd title it "Fail with helpful error message on Debian if incorrect package_version is used with absolute_source".
I think this should read "For some reason |
| @@ -61,7 +61,10 @@ | |||
| $_install_options = $install_options | |||
| if $::puppet_agent::absolute_source { | |||
| # absolute_source means we use dpkg on debian based platforms | |||
| $_package_version = 'present' | |||
| if ($package_version != 'present' and $package_version != 'latest') { | |||
There was a problem hiding this comment.
isn't installed also allowed?
For some reason absolute_path for Debian systems is statically set to 'present' in install.pp.
This seems to be because dpkg can't accept $package_version if it is set to a version or 'auto'.
This makes you unable to use a puppet installer locally placed on the system to upgrade your puppet agent on Debian.
Why not set $_package_version = $package_version and then just make sure that it is either 'present' or 'latest' and otherwise fail?