EXPECTED TO FAIL: tests are not correctly checking package_version

[mbaynton]

It appears that for some reason, the value being provided to the class under test for the package_version parameter does not in fact get set to each of the values in the test array. Instead, the last value listed is passed to the class under test repeatedly, the number of times that there are elements in the array of strings that are expected to be valid package versions.

This can be demonstrated several ways; besides my expectation on the parameter value that the puppet-agent class receives, you could also add values like 1.3.5banana (from the array of versions expected to be invalid) to the array of versions expected to be valid, in any position but the last one, and see that the tests do not fail as they should.

I've spent several hours fidgeting and trying to determine why this is the case, but I am unfamiliar with ruby and the underlying issue probably requires a deep knowledge of ruby and/or this testing framework. I need to move on, but wanted to bring to the maintainers' attention that the test suite is not actually checking all the inputs it appears to be checking.

[puppetcla]

Waiting for CLA signature by @mbaynton

@mbaynton - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

[mbaynton]

Presumably exempt from CLA as it's trivial and not likely to be merged as-is; intent is only to highlight a bug

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[joshcooper]

Closing and reopening to trigger CI runs