Allow a singular numeric port for the --to-ports parameter
#1199
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcoxmoz
force-pushed
the
numeric-toports
branch
from
6c1c341
to
bc93563
Compare
gcoxmoz
force-pushed
the
numeric-toports
branch
from
29b7d00
to
c86ec69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows a numeric port for
--to-ports/firewall.toportsAdditional Context
Variant[Integer[0, 65535]is Stdlib::Port, but using that fails with "firewall.toports references an unresolved type 'Stdlib::Port'" so oh well.Related Issues (if any)
Resolves #1186
Checklist
puppet apply)