Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-1422) - Add Language Server Input to release_prep #847

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 commented Oct 5, 2023

Summary

This PR will now allow maintainers to specify the version of the language server to be shipped with the new vscode extension release.

Additional Context

Use of more concise syntax - opted for jq over sed.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

Verification

When a language server release is provided -> #848
When a language server release is not provided -> #849 & https://github.com/puppetlabs/puppet-vscode/actions/runs/6421160889/job/17434877805 (step is skipped)

@david22swan david22swan merged commit 6865447 into main Oct 6, 2023
5 of 6 checks passed
@david22swan david22swan deleted the CAT-1422-update_workflows branch October 6, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants