(CAT-2094) Reusable shellcheck #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shellcheck has been moved into gem_ci, not module_ci. Therefore, this change would not work as of now. A decision will be made soon on whether to implement this check for modules as well or not. Until then, do not merge this. |
LukasAud
changed the title
Shellcheck has been moved to our reusable workflows repository and is now part os our CI testing. As such, we are removing the action from here and enabling it to be called.
LukasAud
force-pushed
the
CAT-2013-reusable_shellcheck
branch
from
f91a01c to
bff80cf
Compare
|
Shellcheck has now been moved into module_ci.yml. Commit 71acc3f was used for testing, now undone. This PR is ready to merge. |
jordanbreen28
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shellcheck has been moved to our reusable workflows repository and is
now part os our CI testing. As such, we are removing the action from
here and enabling it to be called.
Checklist