tasks require path to inventory yaml #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
h0tw1r3
force-pushed
the
inventory
branch
2 times, most recently
from
a58dde7 to
a134735
Compare
h0tw1r3
changed the title
2 tasks
bastelfreak
approved these changes
Apr 30, 2024
|
Related to #167 |
bastelfreak
previously approved these changes
May 3, 2024
h0tw1r3
force-pushed
the
inventory
branch
2 times, most recently
from
dc6aa2e to
4cbdb0c
Compare
|
hey @h0tw1r3 - this is a great change. Could you look to fix the tests and rebase the PR? |
provision tasks document the inventory parameter as the "location to inventory file", so make it behave as such.
|
@jordanbreen28 rebased |
jordanbreen28
previously approved these changes
Jul 9, 2024
|
@h0tw1r3 thanks! Just noticed after approving we've got an error in ci.. https://github.com/puppetlabs/provision/actions/runs/9853591847 |
jordanbreen28
approved these changes
Jul 9, 2024
|
thanks @h0tw1r3! Amazing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tasks document the inventory parameter as the "location to inventory file", so make it behave as such.
changes are backwards compatible with puppet_litmus <= 1.3.0
this is the beginning of uncoupling the litmus specific assumptions in the provision module.