Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(BUGFIX) Change how packaging is pinned #374

Merged
merged 1 commit into from
Nov 7, 2024
Merged

(BUGFIX) Change how packaging is pinned #374

merged 1 commit into from
Nov 7, 2024

Conversation

david22swan
Copy link
Member

@david22swan david22swan commented Nov 7, 2024 •
edited
Loading

Summary

Pin was coming through incorrectly and causing the build step to fail, pinning it in this way seems to work as is expected.

Screenshot 2024-11-07 at 5 32 11 PM

Checklist

  • 🟢 Spec tests.
  • Manually verified.

@david22swan david22swan added the bug label Nov 7, 2024
@david22swan david22swan requested a review from a team as a code owner November 7, 2024 17:26
gavindidrichsen
gavindidrichsen approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@gavindidrichsen gavindidrichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavindidrichsen gavindidrichsen merged commit 26a4f68 into main Nov 7, 2024
2 checks passed
@gavindidrichsen gavindidrichsen deleted the packaging_fix branch November 7, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavindidrichsen gavindidrichsen gavindidrichsen approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david22swan @gavindidrichsen