(maint) Update powershell helpers to escape correctly for linux #2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdonaldseanp
force-pushed
the
fix_ps_hash_escaping
branch
from
63f46f5 to
26cd001
Compare
jpogran
suggested changes
Feb 16, 2021
This commit updates the PuppetBolt powershell module to correctly escape hash parameters for linux platforms. Conversation in this thread: MicrosoftDocs/PowerShell-Docs#2361 describe the circumstances of why interpolation breaks. The fix is to include backslash escape chars for all quotes in hash parameters if the powershell function is running on linux !no-release-note
mcdonaldseanp
force-pushed
the
fix_ps_hash_escaping
branch
from
26cd001 to
c2c466c
Compare
jpogran
approved these changes
Feb 19, 2021
|
@mcdonaldseanp just need to update CI to run these tests on nix and macos, and adjust the pester tests to account for the text changes and we're good to go! |
This commit updates the pester tests for the pwsh module to correctly test for the new format of params parsing on unix based platforms
This commit updates the pwsh module testing to include a matrix of unix, macos and windows platforms instead of just windows
mcdonaldseanp
force-pushed
the
fix_ps_hash_escaping
branch
from
cd58518 to
2ff90e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the PuppetBolt powershell module to correctly escape hash
parameters for linux platforms. Conversation in this thread:
MicrosoftDocs/PowerShell-Docs#2361 describe the
circumstances of why interpolation breaks.
The fix is to include backslash escape chars for all quotes in hash parameters
if the powershell function is running on linux